Skip to content

Commit

Permalink
Remove return value check from queue submit command
Browse files Browse the repository at this point in the history
The queue submit command is already handling return values below
  • Loading branch information
Icemole committed Jul 18, 2024
1 parent 1b4a89a commit f73facb
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
4 changes: 0 additions & 4 deletions sisyphus/load_sharing_facility_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,6 @@ def submit_helper(self, call, logpath, rqmt, name, task_name, rangestring):
logging.info("command: %s" % command)
try:
out, err, retval = self.system_call(bsub_call, command)
if retval != 0:
logging.warning(self._system_call_error_warn_msg(bsub_call))
time.sleep(gs.WAIT_PERIOD_QSTAT_PARSING)
continue
except subprocess.TimeoutExpired:
logging.warning(self._system_call_timeout_warn_msg(bsub_call))
time.sleep(gs.WAIT_PERIOD_SSH_TIMEOUT)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -240,10 +240,6 @@ def submit_helper(self, call, logpath, rqmt, name, task_name, start_id, end_id,
while True:
try:
out, err, retval = self.system_call(sbatch_call)
if retval != 0:
logging.warning(self._system_call_error_warn_msg(sbatch_call))
time.sleep(gs.WAIT_PERIOD_QSTAT_PARSING)
continue
except subprocess.TimeoutExpired:
logging.warning(self._system_call_timeout_warn_msg(sbatch_call))
time.sleep(gs.WAIT_PERIOD_SSH_TIMEOUT)
Expand Down
4 changes: 0 additions & 4 deletions sisyphus/son_of_grid_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -256,10 +256,6 @@ def submit_helper(self, call, logpath, rqmt, name, task_name, start_id, end_id,
while True:
try:
out, err, retval = self.system_call(qsub_call, command)
if retval != 0:
logging.warning(self._system_call_error_warn_msg(qsub_call))
time.sleep(gs.WAIT_PERIOD_QSTAT_PARSING)
continue
except subprocess.TimeoutExpired:
logging.warning(self._system_call_timeout_warn_msg(qsub_call))
time.sleep(gs.WAIT_PERIOD_SSH_TIMEOUT)
Expand Down

0 comments on commit f73facb

Please sign in to comment.