memory_allocation_type in SimpleLinuxUtilityForResourceManagementEngi…

…ne now default to PER_NODE
rwth-i6 · Jan 27, 2023 · 4727af3 · 4727af3
1 parent 98a9705
commit 4727af3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- The memory_allocation_type in the slurm engine now default to per_node instead of per_cpu for consistency with other engines
+
 ### Added
 - Support for async workflow definitions. If await tk.async_run(obj) is called sisyphus will wait until all Path objects inside of obj are available
 - Path has now is_set method

diff --git a/sisyphus/simple_linux_utility_for_resource_management_engine.py b/sisyphus/simple_linux_utility_for_resource_management_engine.py
@@ -45,7 +45,7 @@ class MemoryAllocationType(Enum):
         PER_NODE = "per_node"
 
     def __init__(self, default_rqmt, gateway=None, has_memory_resource=True, auto_clean_eqw=True,
-                 ignore_jobs=[], memory_allocation_type=MemoryAllocationType.PER_CPU):
+                 ignore_jobs=[], memory_allocation_type=MemoryAllocationType.PER_NODE):
         """
 
         :param dict default_rqmt: dictionary with the default rqmts