Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce dim tags to be unique? #48

Closed
albertz opened this issue Oct 29, 2021 · 1 comment
Closed

Enforce dim tags to be unique? #48

albertz opened this issue Oct 29, 2021 · 1 comment
Milestone

Comments

@albertz
Copy link
Member

albertz commented Oct 29, 2021

Related is #17 on how we handle dim tags in general here.

This needs rwth-i6/returnn#632 on the RETURNN side. Which is maybe a flag like behavior_unique_dim_tags = True.

We could just always enable this flag here. See the discussion in rwth-i6/returnn#632 why this might be useful.

I think this also would imply that we always need to have dim tags explicitly (so never just an integer for n_out) but I'm not exactly sure. This is again #17.

@albertz
Copy link
Member Author

albertz commented Dec 22, 2021

We mostly have this already now on returnn-common. E.g. nn.Parameter enforces it. dot only has the reduce argument, so it is not possible that you end up with non-unique dim tags. There might be some other rare cases. But then, as we have dim tags mandatory, it would fail very soon as when you match a non-unique dim tag, it would also error.

So I think this can be closed for now.

@albertz albertz closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant