Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SliceNdLayer now uses GatherLayer to get the slices. #635

Merged
merged 14 commits into from
Sep 16, 2021
Merged

SliceNdLayer now uses GatherLayer to get the slices. #635

merged 14 commits into from
Sep 16, 2021

Commits on Sep 16, 2021

  1. SliceNdLayer now uses GatherLayer to get the slices. The start argume… 

    …nt of SliceNdLayer can now be of any shape and not only of shape (B,) as before.
    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    77a3bc6 View commit details
    Browse the repository at this point in the history

  2. Quick fixes, reintroduced the min_size option and allow size=None in … 

    …order to use the max possible size.
    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    a7840d9 View commit details
    Browse the repository at this point in the history

  3. SliceNdLayer: Changed some lines to their previous version

    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    265331e View commit details
    Browse the repository at this point in the history

  4. SliceNdLayer get_out_data_from_opts: removed batch argument from Dime… 

    …nsionTag because it led to an error
    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    da952e7 View commit details
    Browse the repository at this point in the history

  5. SliceNdLayer: added comment explaining the possible gradient issue of… 

    … the padding
    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    fc7bea3 View commit details
    Browse the repository at this point in the history

  6. SliceNdLayer: create new dimension tag in get_out_data_from_opts and … 

    …reuse it in __init__
    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    e493d92 View commit details
    Browse the repository at this point in the history

  7. SliceNdLayer: small changes

    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    8ed48ac View commit details
    Browse the repository at this point in the history

  8. dyn_size can now have shapes other than [B]

    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    27fb887 View commit details
    Browse the repository at this point in the history

  9. Added dyn_size in case that seq_lens is None

    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    914f563 View commit details
    Browse the repository at this point in the history

  10. Changed hard-coded index to time_dim_axis and added assert

    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    20c6222 View commit details
    Browse the repository at this point in the history

  11. Added test for case that start is of shape [B] in loop and of shape [… 

    …B,T] when optimized out of the loop
    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    0e563b3 View commit details
    Browse the repository at this point in the history

  12. Small fix for compatibility in test

    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    54b451d View commit details
    Browse the repository at this point in the history

  13. Added blank lines

    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    d329ce4 View commit details
    Browse the repository at this point in the history

  14. Added min_size compatibility and small beam fix

    @robin-p-schmitt
    robin-p-schmitt committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    b08d75d View commit details
    Browse the repository at this point in the history