Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data: add dim tag format stag-single:<idx>:<name> #490

Merged
merged 4 commits into from
Apr 27, 2021

Conversation

vieting
Copy link
Contributor

@vieting vieting commented Apr 26, 2021

I added the format stag-single:<idx>:<name> for dim tags to be able to distinguish spatial axes in pytorch-to-returnn. idx is relative to the matching stags, i.e., it is the index among the list of spatial dims matching name.

@vieting vieting requested a review from albertz April 26, 2021 15:20
@vieting
Copy link
Contributor Author

vieting commented Apr 26, 2021

fixed issue with python 2 compatibility

@vieting
Copy link
Contributor Author

vieting commented Apr 26, 2021

Find related PR in pytorch-to-return here rwth-i6/pytorch-to-returnn#36

returnn/tf/util/data.py Outdated Show resolved Hide resolved
returnn/tf/util/data.py Outdated Show resolved Hide resolved
@albertz
Copy link
Member

albertz commented Apr 26, 2021

Btw, stag-single is the first prefix I came up with. But I'm not sure if this is really good. Do you maybe have better ideas? Or you think it's ok?

@vieting
Copy link
Contributor Author

vieting commented Apr 26, 2021

I think it's okay. Maybe something like stag-unique or stag-index otherwise? I added the comments to make clear what this is intended for.

returnn/tf/util/data.py Outdated Show resolved Hide resolved
@albertz albertz merged commit df3e1d0 into rwth-i6:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants