Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvLayer with_bias=False default is inconsistent to LinearLayer with_bias=True default #787

Closed
albertz opened this issue Nov 27, 2021 · 2 comments · Fixed by #842
Closed
Assignees

Comments

@albertz
Copy link
Member

albertz commented Nov 27, 2021

I don't really know if we should do anything now, or change this.
I just want to raise this issue here.
Maybe we can also just close it if this is fine or we cannot really do anything about it now.

I also want to know whether one of the settings is very unexpected so users might have used it wrongly. That would be an argument to make it explicit or change the default (of course via new behavior version (#508)).

Also, as usual, we should check the defaults of other frameworks.

So in all cases, it seems that with_bias=True would be more expected.

@albertz
Copy link
Member Author

albertz commented Dec 3, 2021

There was not so much feedback yet (also not on Slack).

I think with_bias=True makes more sense to have it consistent to everything else.

The question is how to introduce this. Just via a new behavior version?

@vieting
Copy link
Contributor

vieting commented Dec 3, 2021

I agree with_bias=True is more consistent. A new behavior version makes sense to me.

albertz added a commit that referenced this issue Dec 7, 2021
Fix #787.

Introduces new behavior version (#508).
albertz added a commit that referenced this issue Dec 7, 2021
Fix #787.

Introduces new behavior version (#508).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants