Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MHSA module, Conformer block and encoder with relative PE #55
Add MHSA module, Conformer block and encoder with relative PE #55
Changes from 14 commits
751da88
873042a
e066c60
61b87f5
591c777
56a1d48
69f733c
4df2739
8f9d2c2
647ee05
31fec38
2b19cd3
2bf2c89
600752e
7eb61a1
b8db085
83b23c9
c2a301f
a4929dc
338ff2c
c0c706e
7f4decd
5bf24d2
0b9fb9d
f9cdf6e
1137f24
33aa1f1
88f3702
fa3c4ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a strong issue, but why do you have dropout here (in convolution) as explicit module but not for Feed-Forward and MHSA? I think this should be consistent. @michelwi @christophmluscher @curufinwe I would prefer to have it explicit, because then it is printed when you print the model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just followed the V1 implementations. But I could make them all modules. Anyone against that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK with the suggested change. It would improve readability :)