Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set explicit execution provider #36

Merged
merged 1 commit into from
Sep 22, 2023
Merged

set explicit execution provider #36

merged 1 commit into from
Sep 22, 2023

Conversation

JackTemaki
Copy link
Contributor

No description provided.

@albertz
Copy link
Member

albertz commented Sep 22, 2023

Why is this needed? The test was already working without that, or not?

If there is a reason this is needed, I think this reason should also be stated as a comment in the code.

If there is no reason for this change, then I don't understand why to make this change.

@JackTemaki
Copy link
Contributor Author

JackTemaki commented Sep 22, 2023

I wanted to secretly just test and merge this without comment, but then the tests did not start.

The reason for this PR is the failed test:

FAILED tests/test_blstm.py::test_blstm_onnx_export - ValueError: This ORT build has ['AzureExecutionProvider', 'CPUExecutionProvider'] enabled. Since ORT 1.9, you are required to explicitly set the providers parameter when instantiating InferenceSession. For example, onnxruntime.InferenceSession(..., providers=['AzureExecutionProvider', 'CPUExecutionProvider'], ...)

This is likely because onnxruntime was updated from 1.15 to 1.16

@JackTemaki
Copy link
Contributor Author

Test is running now, so I just merge.

@JackTemaki JackTemaki merged commit aaa51af into main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants