add unhashed_package_root and PartialImport #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackTemaki
requested review from
albertz,
curufinwe,
christophmluscher,
mmz33,
michelwi,
Judyxujj,
SimBe195,
vieting and
Atticus1806
|
Prerequisite for #156 |
albertz
reviewed
Jul 31, 2023
albertz
reviewed
Aug 2, 2023
|
Okay somehow a rebase did something wrong here, let me figure it out. |
JackTemaki
force-pushed
the
nick-partial-import
branch
from
72a345c to
f8922bb
Compare
|
Reviews please! |
Atticus1806
reviewed
Aug 17, 2023
Co-authored-by: Benedikt Hilmes <[email protected]>
Atticus1806
approved these changes
Aug 17, 2023
michelwi
reviewed
Aug 31, 2023
SimBe195
approved these changes
Sep 7, 2023
JackTemaki
force-pushed
the
nick-partial-import
branch
from
59e1261 to
511cb8f
Compare
michelwi
approved these changes
Sep 7, 2023
|
As @curufinwe wanted to move it later to i6_core, I will just merge it now. If there are changes requested we can do this as follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unhashed_package_rootallows to create "movable" configs that do not change their hash when moved to another location, which is problematic behavior of the current "Import" class. Then, this also adds aPartialImportobject which allows to import a callable with a set of pre-defined and hashed parameters. This can be used to for passing extra arguments to e.g.get_modelor another hook function.I do not like that
unhashed_package_rootis Optional, but I also do not see a way around it without breaking already existing things.