Add OnnxExportJob #429
Merged
Add OnnxExportJob #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackTemaki
requested review from
albertz,
curufinwe,
christophmluscher,
mmz33,
michelwi,
Judyxujj,
SimBe195,
vieting,
ZijYang and
Atticus1806
michelwi
reviewed
Jul 17, 2023
returnn/compile.py
Outdated
Comment on lines
236
to
237
| if isinstance(checkpoint, Checkpoint): | ||
| raise ValueError("Tensorflow checkpoint export is currently not supported") |
There was a problem hiding this comment.
so then remove (tf) Checkpoint from typehint?
returnn/compile.py
Outdated
| @@ -203,3 +205,62 @@ def run(self): | |||
| shutil.move(files[0], self.out_op.get_path()) | |||
| if len(files) > 1: | |||
| shutil.move(files[1], self.out_grad_op.get_path()) | |||
|
|
|||
|
|
|||
| class OnnxExportJob(Job): | |||
There was a problem hiding this comment.
If the Job anyway only supports PT based models, then we can include it in the name?
Suggested change
| class OnnxExportJob(Job): | |
| class PtToOnnxExportJob(Job): |
albertz
reviewed
Jul 17, 2023
Co-authored-by: Albert Zeyer <[email protected]>
Atticus1806
approved these changes
Jul 18, 2023
SimBe195
approved these changes
Jul 18, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
15 tasks
albertz
added a commit
to rwth-i6/returnn
that referenced
this pull request
Jul 19, 2023
This comment was marked as resolved.
This comment was marked as resolved.
albertz
reviewed
Jul 19, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
vieting
approved these changes
Jul 19, 2023
albertz
requested changes
Jul 19, 2023
albertz
reviewed
Jul 19, 2023
albertz
reviewed
Jul 19, 2023
Co-authored-by: Albert Zeyer <[email protected]>
albertz
approved these changes
Jul 19, 2023
Atticus1806
pushed a commit
that referenced
this pull request
Oct 2, 2023
A wrapper job around the `torch_export_to_onnx.py` tool of RETURNN. Co-authored-by: Albert Zeyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A wrapper around the Returnn-Tool. Be aware that I never tested a "normal" pipeline with this, I just used some dummy
torch_export_to_onnx.pyscript to verify this jobs works.