Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add corrected applicator to linear alignment #407

Merged
merged 11 commits into from
May 11, 2023
Merged

add corrected applicator to linear alignment #407

merged 11 commits into from
May 11, 2023

Conversation

christophmluscher
Copy link
Contributor

@Marvin84 can I apply this like this to the linear alignment step?

@christophmluscher christophmluscher self-assigned this May 10, 2023
@Marvin84
Copy link
Contributor

@Marvin84 can I apply this like this to the linear alignment step?

Looks good.
Once you ran this, please send me your alignment.config of the resulting job so that I can double-check.

@christophmluscher
Copy link
Contributor Author

I am not sure why the job tests are failing now. It fails at from typing import Literal. The Literal is only available Python >= 3.8

The tests are performed with Python 3.7 but the tests did not fail before...

@JackTemaki you have an idea?

Atticus1806
Atticus1806 reviewed May 11, 2023
View reviewed changes
am/config.py Outdated Show resolved Hide resolved
@Atticus1806
Copy link
Contributor

I have to be honest. I have no clue 😅

@Marvin84
Copy link
Contributor

I have to be honest. I have no clue 😅

There is a rasr PR for this : rwth-i6/rasr#14

@christophmluscher christophmluscher mentioned this pull request May 11, 2023
Closed
@Atticus1806
Copy link
Contributor

There is a rasr PR for this : rwth-i6/rasr#14

Thanks, but I was referring to the python test failing or rather why this only comes up now ^^

Atticus1806
Atticus1806 requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@Atticus1806 Atticus1806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if we bump to 3.8 I would revert the "fix" to make the test run.

@christophmluscher christophmluscher merged commit 0ae7ebe into main May 11, 2023
@christophmluscher christophmluscher deleted the chris-linear-applicator branch May 11, 2023 13:24
Atticus1806 pushed a commit that referenced this pull request Oct 2, 2023
@christophmluscher @Atticus1806
add corrected applicator to linear alignment (#407)
9f24bf3 
* add corrected applicator to linear alignment

* add sis hash exclude

* revert

* change import and rerevert

* more detailed import

* exclude test

* possible fix

* black

* more

* add doc string

* removed -> py3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marvin84 Marvin84 Marvin84 approved these changes

@Atticus1806 Atticus1806 Atticus1806 approved these changes

@JackTemaki JackTemaki Awaiting requested review from JackTemaki

Assignees

@christophmluscher christophmluscher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophmluscher @Marvin84 @Atticus1806