Polymer3.0 #1
Merged
Polymer3.0 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges are given in the README
…stName to be used instead of oidc preferred username
… element must not be set (see https://stackoverflow.com/a/47305152)
…_computeLogin so that a provided login-name is sufficient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are mostly syntax related. Other than before the dropdown button is now always active and does not check whether a user is logged in. This is due to the fact that the widget may be loaded before any authenticating information is available. In the same vein the send-cookie attribute can be used to send the user information related ajax requests from the ready() function even when no valid login data is provided.
Other than that the X-select element did not show up properly and I don't know why, so it got replaced by a simple iron-dropdown, and the paper-dialogs are not modal anymore because the backdrop had a faulty z-index and I could not figure out how to circumvent this issue