Remove appendix from Apache license #1390
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I understand, the boilerplate notice in the Apache license's appendix is just meant to be part of the instruction on how to apply the license on a program file and not to actually be modified with the copyright year and owner of the open source project (as in ac4cca7). It should be kept as:
But people often and understandably get confused by it and think it needs to be updated. To avoid confusion, we can simply remove the appendix. The license doesn't actually require that section in the distribution, and other projects have removed it (e.g. see rust-lang/rust#67734). As highlighted in that Rust PR, it is safe to remove:
It was removed from the Rust project for a different reason — they don't practice putting a license header at the top of each file so they removed it to avoid that confusion.
Alternatively, we can keep the appendix and just revert the change in ac4cca7. Let me know if you'd like me to update this PR to do just that. Or, we can keep things as it is, and just close this PR and move on to more important issues.