Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nanopb support #180

Merged
merged 1 commit into from
Mar 17, 2023
Merged

feat: add nanopb support #180

merged 1 commit into from
Mar 17, 2023

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Mar 13, 2023

Resolves #164

Add nanopb support

@strophy
Copy link
Collaborator Author

strophy commented Mar 13, 2023

This currently fails with:

#0 1.036 [63] Error loading Python lib '/usr/bin/libpython3.11.so.1.0': dlopen: Error loading shared library /usr/bin/libpython3.11.so.1.0: No such file or directory
#0 1.036 --nanopb_out: protoc-gen-nanopb: Plugin failed with status code 255.

Is there any way to build this without 33MB of Python dependencies?

@strophy strophy marked this pull request as ready for review March 16, 2023 05:33
@strophy
Copy link
Collaborator Author

strophy commented Mar 16, 2023

@rvolosatovs this increases the image size by 20MB after compression, but otherwise works fine.

@rvolosatovs
Copy link
Owner

Just a small question, do we need to do anything to make Renovate pick up updates for this one?

@strophy
Copy link
Collaborator Author

strophy commented Mar 17, 2023

Yes, I forgot to do that for a couple of the recent additions so I will open a new PR now to update Renovate.

@strophy strophy merged commit 3021259 into main Mar 17, 2023
@strophy strophy deleted the feat/nanopb branch March 17, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add nanopb support
2 participants