Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dart docker tag to v2.19.4 #166

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 8, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
dart patch 2.19.1 -> 2.19.4

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot changed the title chore(deps): update dart docker tag to v2.19.2 chore(deps): update dart docker tag to v2.19.3 Mar 2, 2023
Dockerfile Outdated
@@ -380,7 +380,8 @@ RUN apt-get install -y curl
RUN mkdir -p /dart-protobuf
ARG PROTOC_GEN_DART_VERSION
RUN curl -sSL https://api.github.com/repos/google/protobuf.dart/tarball/protoc_plugin-${PROTOC_GEN_DART_VERSION} | tar xz --strip 1 -C /dart-protobuf
WORKDIR /dart-protobuf/protoc_plugin
WORKDIR /dart-protobuf/protoc_plugin
ARG PUB_HOSTED_URL=https://pub.flutter-io.cn
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment briefly explaining what this is and what it's for?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, was just going to ask you about this. This is the bug that has been blocking all of our CI runs for the last month, just now getting a bit of time to look at it.

The official host for the Dart package manager is https://pub.dartlang.org/, which can be searched at https://dart.dev/. Several users on corporate networks, in countries with poor connectivity and internet restrictions report difficulty connecting to this host, and other users report the same difficulty when running in CI and/or emulation. It seems the remote server has a strict security configuration that is dropping connections in some cases if the wrong user agent is used.

The easiest solution is to use a mirror of the package host with a different configuration that doesn't drop the connection for whatever reason. These tend to be hosted in China, due to the enormous popularity of Android there, and the difficulty in accessing outside internet, particularly unpredictable speed throttling which is super annoying when trying to download large packages. The URL is recommended in the Flutter docs.

I don't think there is any security risk because the packages are still verified for authenticity and integrity with a signature and checksum, like with any other package manager. But if you prefer, we can disable ARM build for Dart instead to avoid depending on the non-canonical package manager URL.

@renovate renovate bot changed the title chore(deps): update dart docker tag to v2.19.3 chore(deps): update dart docker tag to v2.19.4 Mar 12, 2023
@strophy strophy merged commit 99ae1ce into main Mar 12, 2023
@strophy strophy deleted the renovate/dart-2.x branch March 12, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants