Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only renovate node lts versions #133

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Dec 12, 2022

This PR configures renovate to extract the full Node version from the Docker tag, and update that with LTS versions only while pinning a static version of Alpine. This is necessary as Renovate devs figure out how to best handle complex docker tags like this.

Since it takes some time for Alpine releases (e.g. the new alpine:3.17) to become available in downstream projects based on it (e.g. node:18.12.1-alpine3.17 does not exist yet), I would suggest we leave Renovate's Alpine PR open when it occurs every ~6 months and manually update any alpine versions we specify in deps (e.g. also rust:1.65.0-alpine3.16) as they become available, merging it only when all deps are based on the same updated Alpine version.

Copy link
Owner

@rvolosatovs rvolosatovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@rvolosatovs rvolosatovs merged commit 2ac611b into main Dec 15, 2022
@rvolosatovs rvolosatovs deleted the ci/renovate-node-lts branch December 15, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants