feat: xx-cargo #114
Merged
feat: xx-cargo #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@rvolosatovs this fixes our CI problem. Let's merge this first, then we can use it unblock all the other pending PRs 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are having problems moving forward with PRs on this repo because CI is failing. Investigation showed this was likely occurring due to an OOM error while attempting to compile two Rust targets simultaneously in QEMU. On my local machine, this would consume 32GB RAM + 8GB swap and hard crash the system. I think this was also the cause of CI logs not being available, the runner probably died before anything could be uploaded (even though the stream was visible during a run).
https://github.com/tonistiigi/xx/ recently added support for Rust, and using the Rust cross compiler shows no significant memory consumption.
stripwas moved to be handled bycargoas well, to ensure that the native toolchain is used to process cross-compiled binaries. And caching support was added to the Rust section of the Dockerfile to speed up local development and support future caching in CI.