feat: add ts-protoc-gen plugin
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contribution, please fix CI |
rvolosatovs
reviewed
Nov 25, 2022
rvolosatovs
reviewed
Nov 25, 2022
rvolosatovs
approved these changes
Nov 25, 2022
rvolosatovs
requested changes
Nov 25, 2022
rvolosatovs
force-pushed
the
feat/add-protoc-gen-ts-plugin
branch
from
cea8ee3
to
316884a
Compare
|
@strophy looking at CI log, I am not sure UPX works for the TS plugin. We can just drop the commit, merge this PR and perhaps file an issue to investigate whether this is at all possible |
strophy
force-pushed
the
feat/add-protoc-gen-ts-plugin
branch
from
316884a
to
e42e045
Compare
rvolosatovs
approved these changes
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR duplicates stalled #105 as requested by @strophy