Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spoa::Graph::GenerateConsensus additional overload #73

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

tbrekalo
Copy link
Contributor

Added an for spoa::Graph::GenerateConsensus that takes min_coverage argument and accepts pointer to coverage summary vector. The goal is to use this overload with new racon version.

src/graph.cpp Show resolved Hide resolved
include/spoa/graph.hpp Outdated Show resolved Hide resolved
@rvaser
Copy link
Owner

rvaser commented Nov 27, 2023

Please squash the commits into one.

…n_coverage and summary

Added an for Graph::GenerateConsensus that takes min_coverage argument and accepts pointer to coverage summary vector.
The goal is to use this overload with new racon version.

tbrekalo-generate-consensus-overload: formatting

tbrekalo-generate-consensus-overload: addressing PR comments
@tbrekalo tbrekalo force-pushed the tbrekalo-generate-consensus-overload branch from 7c97e93 to a2b6f9f Compare November 27, 2023 11:03
@rvaser rvaser merged commit 4d8805d into rvaser:master Nov 27, 2023
4 checks passed
@tbrekalo tbrekalo deleted the tbrekalo-generate-consensus-overload branch November 27, 2023 17:14
@tbrekalo
Copy link
Contributor Author

Could you please potentially create a new release including these changes? v4.1.1 for instance?

@rvaser
Copy link
Owner

rvaser commented Nov 30, 2023

Tagged as 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants