Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libc on Redox. #15

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Use libc on Redox. #15

merged 2 commits into from
Oct 16, 2023

Conversation

4lDO2
Copy link
Contributor

@4lDO2 4lDO2 commented Oct 14, 2023

Now that redox_syscall is no longer meant to be used by application code, this MR makes thread-id use the libc functions instead.

ruuda and others added 2 commits October 16, 2023 20:13
This ensures that updates to e.g. the Cargo lockfile will be written by
the oldest supported version, so we don't accidentally introduce an
incompatibility.
@ruuda
Copy link
Owner

ruuda commented Oct 16, 2023

Thank you for taking the time to open a pull request. This looks like a nice simplification. I modified the changes to Cargo.lock to keep the format compatible with Rust 1.34.2 (the current minimum version), but the versions are otherwise the same.

I don’t use Redox myself but I trust you that this work with libc 0.2.149. I’ll make a new release shortly.

@4lDO2
Copy link
Contributor Author

4lDO2 commented Oct 16, 2023

Thanks for fixing the PR for older compiler versions!

Rust's libstd has used pthreads via libc on Redox for quite a while (and Redox is #[cfg(unix)] now), so this change could as well have been submitted earlier.

@ruuda ruuda merged commit 821721a into ruuda:master Oct 16, 2023
5 of 6 checks passed
@ruuda
Copy link
Owner

ruuda commented Oct 16, 2023

Published as v4.2.1, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants