Subtype TLV fixes! #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I initially used JSON, but it was not human-writable. The simple DSL is much more human-writable, and readable. Signed-off-by: Rusty Russell <[email protected]>
Works with current c-lightning master branch, as long as it's built with --enable-developer. Signed-off-by: Rusty Russell <[email protected]>
Very simple successful open. Signed-off-by: Rusty Russell <[email protected]>
Does a simple dust HTLC and a non-dust HTLC. Both fail. Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
This helps for testing that we handle it correctly. Signed-off-by: Rusty Russell <[email protected]>
Preliminary parsing for subtypes. Probably need something on the unpacking side also.
rustyrussell
force-pushed
the
guilt/tests
branch
from
6bb7f86 to
4e337f0
Compare
rustyrussell
force-pushed
the
guilt/tests
branch
from
4e337f0 to
2d52316
Compare
rustyrussell
added a commit
that referenced
this pull request
May 18, 2020
`u8` isn't a type; see BOLT #1 "Fundamental Types". Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
added a commit
that referenced
this pull request
Aug 3, 2020
* Rename all the 'varint' to 'bigsize'. Having both is confusing; we chose the name bigsize, so use it explicitly. Signed-off-by: Rusty Russell <[email protected]> * BOLT 7: use `byte` instead of `u8`. `u8` isn't a type; see BOLT #1 "Fundamental Types". Signed-off-by: Rusty Russell <[email protected]> * BOLT 1: promote bigsize to a Fundamental Type. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
pushed a commit
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches for TLV's and subtypes (WIP!)