Get referenced obj using dynamic GVK API #1
Conversation
Signed-off-by: Nitish Malhotra <[email protected]>
| pub async fn resolve_uri( | ||
| &self, | ||
| client: kube::Client, | ||
| ) -> Result<url::Url, Box<dyn std::error::Error>> { |
There was a problem hiding this comment.
It would be nice to keep our error model in-line with kube's by sticking with thiserror wrappers of Error.
If we add a Variant to knative error with a #[from] kube-client::Error then it will automatically implement TryFrom which gives us back ? operator without resorting to Box<dyn std::error::Error>. We may need to drop Clone and Copy derives, but that's ok!
Our error can look like this:
use kube::error::Error as KubeError;
#[derive(Error, Debug)]
pub enum Error {
/// Discovery errors
#[error("Error from discovery: {0}")]
Discovery(#[source] DiscoveryError),
/// Kube errors
#[error("Error from kube: {0}")]
KubeError(#[from] KubeError),
}There was a problem hiding this comment.
Also, the Discovery Variant is admittedly not very thought out. Feel free to scratch or rework it when we add the actual Errors that can occur during KReference uri resolution!
| Ok(url) | ||
| } | ||
| (None, Some(ref uri)) => Ok(uri.clone()), | ||
| (None, None) => Err(Error::Discovery(DiscoveryError::EmptyDestination)) | ||
| (None, None) => Err(Box::new(Error::Discovery(DiscoveryError::EmptyDestination))), |
There was a problem hiding this comment.
We can remove the box once we add the kube::Error Variant to our error
duckv1.AddressableTypeand get URL fromstatus. This probably requires the type to be defined and implemented first.Signed-off-by: Nitish Malhotra [email protected]