Add setters for expiring and unique jobs (Enterprise Faktory) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustworthy
changed the title
rustworthy
force-pushed
the
feat/enterprise-faktory-features
branch
from
fa86dbd
to
3db6a70
Compare
|
Just curious — did you intend to file this as a PR against https://github.com/jonhoo/faktory-rs? |
The idea was it would naturally be moved as soon as the job builder is merged, while 1) JobBuilder looks like a convenient place to add those setters to and 2) that would help avoid conflicts. |
rustworthy
force-pushed
the
feat/enterprise-faktory-features
branch
from
3ac5917
to
08c3dbb
Compare
rustworthy
force-pushed
the
feat/enterprise-faktory-features
branch
from
08c3dbb
to
3d63433
Compare
rustworthy
pushed a commit
that referenced
this pull request
Jan 3, 2024
…odecov-action-3 Bump codecov/codecov-action from 2 to 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue
To keep it ergonomic, implementing it against JobBuilder feature branch.
Keeping it under the feature called "ent", because looks like it is already a common abbreviation/label for Enterprise Faktory.
Referencing the Faktory's wiki with regard to API.
Covering these Ent Faktory features:
Will be added as separate PRs: