Update using-your-library.md #892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/src/tutorials/hybrid-applications-with-webpack/using-your-library.md
Outdated
Show resolved
Hide resolved
…-library.md Co-authored-by: Avery Harnish <[email protected]>
janriemer
suggested changes
Sep 6, 2020
| @@ -64,6 +64,14 @@ import("../crate/pkg").then(module => { | |||
| }); | |||
| ``` | |||
|
|
|||
| ## Install `npm` Dependencies | |||
|
|
|||
| Before your first run, don't forget to install npm dependencies in your project's root directories: | |||
There was a problem hiding this comment.
Suggested change
| Before your first run, don't forget to install npm dependencies in your project's root directories: | |
| Before your first run, don't forget to install npm dependencies in your project's root directory: |
Shouldn't this be "project's root directory" (no plural)? Because in line 77 it is also in singular form:
https://github.com/rustwasm/wasm-pack/pull/892/files#diff-4fab3c527d81230563c65b7a11c52ac2R77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves rustwasm/rustwasm.github.io#58
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨