-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update chromedriver download URL, resolve test issues #1391
Conversation
Seems like there's some unfortunate caching issues I'll have to dig into. |
Thank you for looking into this! Appreciated! |
This issue seems to be resolved now for the sake of this PR. However, in general I've found some consistency issues with trying to determine what paths to cache when manually in many of my other projects. Are you open to switching to something like Swatinem/rust-cache or mozilla-actions/sccache-action? I've used both successfully quite a bit, though recently all of my projects have moved to the latter. If so I can open up another PR after this is cleared to merge to switch out the caching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
This fixes a few things to get CI working for the repo again:
matches_cargo
accept both the old and new formats.macos-latest
default, the current geckodriver setup fails for that platform.It's not entirely obvious to me why at this point. Downgrading to theEdit: It seems like the only thing preventing macOS from working was that I needed to manually install Firefox. I'm guessing this was available in the previous macOS runners by default.macos-13
runner has these tests working again. This is probably the most.. questionable change as it'd be better to track down why the latest runners don't work.Make sure these boxes are checked! 📦✅
rustfmt
installedcargo fmt
on the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨
Closes #1390