Lazily initialize memory views #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops load-time errors in versions of Safari before 15 if the `BigInt64Array` or `BigUint64Array` memory views are included but never used. Pointed out in rustwasm#2716 (comment).
|
Could this perhaps just be done for u64? I think that this was how it once was long ago and it was switched to the current pattern as it was slightly more performant. |
|
I think you're thinking of #2886, which did include that change, but it wasn't where the performance wins came from; it was just another thing I happened to change. |
|
Ah sorry, indeed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops load-time errors in versions of Safari before 15 if the
BigInt64ArrayorBigUint64Arraymemory views are included but never used.Pointed out in #2716 (comment).