Allow returning Result<*mut T, _> and Result<*const T, _> from async functions
#3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liamolucko
reviewed
Sep 3, 2022
Comment on lines
+763
to
+793
| impl<T> From<*mut T> for JsValue { | ||
| #[inline] | ||
| fn from(s: *mut T) -> JsValue { | ||
| JsValue::from(s as usize) | ||
| } | ||
| } |
There was a problem hiding this comment.
This should be implemented for *const T as well.
ThomasMarches
changed the title
Result<*mut T, _> from async functionsResult<*mut T, _> and Result<*const T, _> from async functions
|
You need to update diff --git a/crates/macro/ui-tests/async-errors.stderr b/crates/macro/ui-tests/async-errors.stderr
index 492492a1..f4ebb478 100644
--- a/crates/macro/ui-tests/async-errors.stderr
+++ b/crates/macro/ui-tests/async-errors.stderr
@@ -40,8 +40,8 @@ error[E0277]: the trait bound `wasm_bindgen::JsValue: From<BadType>` is not sati
<wasm_bindgen::JsValue as From<&'a String>>
<wasm_bindgen::JsValue as From<&'a T>>
<wasm_bindgen::JsValue as From<&'a str>>
- <wasm_bindgen::JsValue as From<JsError>>
- and 73 others
+ <wasm_bindgen::JsValue as From<*const T>>
+ and 75 others
= note: required because of the requirements on the impl of `Into<wasm_bindgen::JsValue>` for `BadType`
= note: required because of the requirements on the impl of `IntoJsResult` for `BadType`
note: required by `into_js_result`
|
- implemented `From<*mut T>` for `JsValue` - implemented `From<*const T>` for `JsValue` - update CI stderr
Liamolucko
approved these changes
Nov 21, 2022
daxpedda
pushed a commit
to daxpedda/wasm-bindgen
that referenced
this pull request
Nov 27, 2022
daxpedda
pushed a commit
to daxpedda/wasm-bindgen
that referenced
this pull request
Jan 13, 2023
daxpedda
pushed a commit
to daxpedda/wasm-bindgen
that referenced
this pull request
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code does not work currently, the goal of this PR is to fix it.
The base error is:
The same code does compile using a sync function.