Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.2.82 #3002

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Bump to 0.2.82 #3002

merged 3 commits into from
Jul 25, 2022

Conversation

GalvinGao
Copy link
Contributor

@GalvinGao GalvinGao commented Jul 22, 2022

Me personally is in great need of #2965 because I'm trying to make vite to work and, as mentioned in Menci/vite-plugin-wasm#5 it appears that such issue has already been fixed. It would be awesome to be able to use vite and typescript as I follow along the tutorial!

@0x1f57
Copy link

0x1f57 commented Jul 22, 2022

Me too

@Liamolucko
Copy link
Collaborator

You should also update the wasm-bindgen-shared schema version, since the schema was changed in #2954:

pub const SCHEMA_VERSION: &str = "0.2.74";

Apart from that, this looks good to me - cc @alexcrichton

@GalvinGao
Copy link
Contributor Author

huh, schema version check failed at https://github.com/rustwasm/wasm-bindgen/runs/7479700475?check_suite_focus=true. I noticed that the hash has also been changed in #2954, but it seems to me that specify version in crates/shared/src/lib.rs in sync with crates/shared/Cargo.toml makes sense to me. Anything I have done wrong?

@ranile ranile requested a review from alexcrichton July 23, 2022 08:19
@Liamolucko
Copy link
Collaborator

That hash is the hash of lib.rs, so you have to update it as well (to "18229224525184165582", as per the CI failure).

The point of it (I think) is to remind people to update the schema version by having that test fail when the schema in lib.rs changes.

@alexcrichton
Copy link
Contributor

Seems reasonable to me to publish, thanks! With CI fixed I can merge and publish/tag.

@GalvinGao
Copy link
Contributor Author

CI passed! Consider squash when merging plz :D

@alexcrichton alexcrichton merged commit 59883ea into rustwasm:main Jul 25, 2022
@GalvinGao GalvinGao deleted the bump-0.2.82 branch July 25, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants