Fix u64 and i64 in Safari 14 #2727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR here on this, but I think that much of this can be simplified. It looks like this is having numbers travel through the u32 array but I don't think that's necessary if the numbers are already manually split. Additionally I don't think the u64 conversion "shims" should really be necessary any more. |
|
Sorry for the late response, life gets in the way sometimes. I think you're right about the U32 Array, I can remove those. Thanks for the feedback. |
|
This got fixed in #3037. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of BigUint64Array and BigInt64Array as Safari 14 does not support them.
I have also run all the u64 and i64 tests and they work as expected.