Implement To/FromWasmAbi traits for boxed slices of JsValue wrappers
#2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review |
Jules-Bertholet
force-pushed
the
master
branch
2 times, most recently
from
d5b13f2
to
1303e3c
Compare
|
Seems reasonable enough to me! Can you be sure to add some tests to exercise all these paths too? |
Jules-Bertholet
force-pushed
the
master
branch
2 times, most recently
from
da04eb8
to
8b2697d
Compare
|
Tests added! |
|
👍 |
Jules-Bertholet
added a commit
to Jules-Bertholet/wasm-bindgen
that referenced
this pull request
Jul 14, 2021
Closed
Jules-Bertholet
added a commit
to Jules-Bertholet/wasm-bindgen
that referenced
this pull request
Jul 14, 2021
Merged
alexcrichton
pushed a commit
that referenced
this pull request
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #111 and #2452.
Typescript type definitions aren't handled yet (stillany[])