Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop requiring the latest git commit in advisory-db to be signed #629

Closed
Shnatsel opened this issue Aug 4, 2022 · 1 comment · Fixed by #816
Closed

Stop requiring the latest git commit in advisory-db to be signed #629

Shnatsel opened this issue Aug 4, 2022 · 1 comment · Fixed by #816
Labels
good first issue Good for newcomers

Comments

@Shnatsel
Copy link
Member

Shnatsel commented Aug 4, 2022

We currently require the presence of some signature on the latest commit in advisory-db repo for cargo audit and other tooling that uses rustsec crate to work.

This is completely useless in that it doesn't add any security. And it has broken production users twice now (both times for just a few minutes before it was noticed and fixed, but still).

We should disable that check.
@Shnatsel Shnatsel mentioned this issue Aug 4, 2022
Closed
@amousset amousset mentioned this issue Aug 4, 2022
Closed
@Jake-Shadle Jake-Shadle mentioned this issue Aug 5, 2022
Merged
@Shnatsel Shnatsel added the good first issue Good for newcomers label Feb 17, 2023
@sidunder
Copy link
Contributor

I'll have a go at creating a PR for this.

@sidunder sidunder mentioned this issue Feb 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove latest commit signature check sidunder/rustsec
2 participants
@Shnatsel @sidunder