Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest commits are not signed, breaking downstream CI #1307

Closed
Bromeon opened this issue Aug 4, 2022 · 4 comments
Closed

Latest commits are not signed, breaking downstream CI #1307

Bromeon opened this issue Aug 4, 2022 · 4 comments

Comments

@Bromeon
Copy link

Bromeon commented Aug 4, 2022

The last commit db78ca0 seems to break some CI integrations, because it's not a verified committer.

cargo-deny fails to fetch the advisory database, with error:

> cargo deny check --config tools/deny.toml
[ERROR] failed to fetch advisory database: git operation failed: no signature on commit db78ca0149f8ed7c8c2d2aea0236edb63a23f362: Revert "Adopt rust-admin 0.8.0 --skip-namecheck rustdecimal" (pinkforest <[email protected]>)
Error: Process completed with exit code 1.

See e.g. this CI run.

@Bromeon
Copy link
Author

Bromeon commented Aug 4, 2022

Thanks for the fast fix in d87417a 🚀

Edit: just verified cargo-deny runs again (CI run).

@tarcieri
Copy link
Member

tarcieri commented Aug 4, 2022

@pinkforest FYI, everything needs to go through a PR workflow

I went ahead and enabled "include administrators" in the branch protections

@tarcieri tarcieri closed this as completed Aug 4, 2022
@Shnatsel
Copy link
Member

Shnatsel commented Aug 4, 2022

Also the requirement for the commit to be signed is useless; I've filed rustsec/rustsec#629 to remove it.

@pinkforest
Copy link
Contributor

pinkforest commented Aug 4, 2022

Yeah this was my stuff up 🤷‍♀️ my apologies - I don't typically like working in branch-in-origin-repo - I had cloned the .git from https:// instead of git@ and was working in the rustdecimal branch and had to switch to the git@ and then forgot to change the branch again.

As to salt to the wounds that branch would require rebase so I went with another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants