stronger deprecations. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in the comment we can't outright `#[deprecate]` this one because it's a trait impl. Instead, promote the deprecation note to the rustdoc comment, add a TODO to remove it outright, and switch our own tests to call `to_owned()` directly in preparation of an eventual removal.
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 94.17% 94.17%
=======================================
Files 14 14
Lines 2505 2505
=======================================
Hits 2359 2359
Misses 146 146
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time: hard deprecate Time::try_from.
Adds a
#[deprecated]annotation. Updates tests to allow deprecated usage of existing approach and to add usage of the preferred trait.subject_name: deprecate From for DnsName.
As mentioned in the commit comment we can't outright
#[deprecate]this one because it's a trait impl.Instead, promote the deprecation note to the rustdoc comment, add a TODO to remove it outright, and switch our own tests to call
to_owned()directly in preparation of an eventual removal.Resolves #47