Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify environment path handling code #134

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Clarify environment path handling code #134

merged 1 commit into from
Sep 9, 2024

Conversation

djc
Copy link
Member

@djc djc commented Sep 9, 2024

Current documentation:

/// If **either** (or **both**) are set, certificates are only loaded from
/// the locations specified via environment variables and not the platform-
/// native certificate store.

This seems like a clearer way of expressing that logic.

@djc djc requested review from cpu and ctz September 9, 2024 08:17
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems a lot clearer to me.

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed this is much nicer, thanks!

@cpu cpu added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit b12e354 Sep 9, 2024
28 checks passed
@cpu cpu deleted the clarify-env branch September 9, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants