Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings linux eventloops2 #880

Merged

Conversation

rukai
Copy link
Contributor

@rukai rukai commented May 24, 2019

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented
warning: attribute must be of the form `#[link(name = "...", /*opt*/ kind = "dylib|static|...",
                                             /*opt*/ cfg = "...")]`
 --> src/platform/linux/dlopen.rs:9:1
  |
9 | #[link="dl"]
  | ^^^^^^^^^^^^
  |
  = note: #[warn(ill_formed_attribute_input)] on by default
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
  = note: for more information, see issue #57571 <https://github.com/rust-lang/rust/issues/57571>

@rukai
Copy link
Contributor Author

rukai commented May 24, 2019

As requested in #879
Feel free to close the original PR or do whatever.
I didn't realize development was happening in a separate branch for now.

@goddessfreya goddessfreya merged commit 93502e0 into rust-windowing:eventloop-2.0 May 24, 2019
@goddessfreya
Copy link
Contributor

Thank you!

@felixrabe felixrabe mentioned this pull request Jun 23, 2019
felixrabe pushed a commit to felixrabe/winit that referenced this pull request Jun 30, 2019
kosyak pushed a commit to kosyak/winit that referenced this pull request Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants