Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename refresh rate #3806

Closed
wants to merge 3 commits into from

Conversation

daxpedda
Copy link
Member

While working on #3802 I wondered about VideoModeHandle::refresh_rate_millihertz()s really long name.
WDYT about renaming it to refresh_rate()?
Alternatively refresh_rate_mh()?

Requires #3802.

@kchibisov
Copy link
Member

I think the reason it's named like that is because we wanted to change the precision of it. Maybe we should return Duration though and call it refresh_rate?

@daxpedda
Copy link
Member Author

Maybe we should return Duration though and call it refresh_rate?

This actually made me look into the definition of the word "Refresh Rate" and while I couldn't find anything better quick, Wikipedia says:

... the number of times per second that a raster-based display device displays a new image.

So it would make sense to use Hz for this. The fact that we renamed it makes a lot of sense now.

Reading through #2352 also convinced me that the way it is right now is better then what I'm proposing here.

@daxpedda daxpedda closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants