android: Forward suspended() and resumed() events and patch up platform-specific documentation
#3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
added
DS - android
C - waiting on author
MarijnS95
added
C - needs discussion
25 tasks
MarijnS95
force-pushed
the
marijn/android/suspend-resume
branch
from
d30b5fb to
8eaaf98
Compare
madsmtm
approved these changes
Sep 2, 2024
5 tasks
MarijnS95
force-pushed
the
marijn/android/suspend-resume
branch
from
8eaaf98 to
41c9c71
Compare
MarijnS95
force-pushed
the
marijn/android/suspend-resume
branch
from
41c9c71 to
0a2a176
Compare
|
(I changed OP to not fix #3779, it just addresses it) |
MarijnS95
force-pushed
the
marijn/android/suspend-resume
branch
from
0a2a176 to
b9bcfd7
Compare
I thought this was fixing the issue entirely but it seems there's still more to address for Web/iOS, and maybe together with more Android changes like #3897? @daxpedda let me know if you can review this, it should address all except one (duplicated) comment from #3765 (review). |
I took the whole day today to do some catch up on my open source responsibilities, so if I don't manage to do it today feel free to go ahead. |
MarijnS95
force-pushed
the
marijn/android/suspend-resume
branch
from
b9bcfd7 to
9a488fb
Compare
…atform-specific documentation Key them off of `onStop()` and `onStart()` which seems to match the other backends most closely. These [Android Activity lifecycle] events denote when the application is visible on-screen, and recommend that any heavy lifting for startup and shutdown happens here, as the application may be demoted to the background and later shut down entirely unless the user navigates back to it. [Android Activity lifecycle]: https://developer.android.com/guide/components/activities/activity-lifecycle
MarijnS95
force-pushed
the
marijn/android/suspend-resume
branch
from
9a488fb to
c44ddc4
Compare
daxpedda
approved these changes
Oct 16, 2024
|
Thanks for all the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3779
Key them off of
onStop()andonStart()which seems to match the other backends most closely. These Android Activity lifecycle events denote when the application is visible on-screen, and recommend that any heavy lifting for startup and shutdown happens here, as the application may be demoted to the background and later shut down entirely unless the user navigates back to it.EDIT: Also addresses some of the late review comments that were posted on #3765.
changelogmodule if knowledge of this change could be valuable to users