Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use self:: when re-importing local module #3757

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Use self:: when re-importing local module #3757

merged 2 commits into from
Jun 24, 2024

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Jun 24, 2024 •
edited
Loading

Follow-up to #3755 (comment). Feel free to merge this once approved.

@madsmtm madsmtm requested a review from daxpedda as a code owner June 24, 2024 10:50
@madsmtm madsmtm mentioned this pull request Jun 24, 2024
Merged
@madsmtm madsmtm added B - bug Dang, that shouldn't have happened S - maintenance Repaying technical debt labels Jun 24, 2024
daxpedda
daxpedda approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@daxpedda daxpedda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

EDIT: can't resolve the merge conflict from my phone 😅.

@madsmtm madsmtm merged commit 8bdd4d6 into master Jun 24, 2024
53 checks passed
@madsmtm madsmtm deleted the madsmtm/use-self-in-reimport branch June 24, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
B - bug Dang, that shouldn't have happened S - maintenance Repaying technical debt
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsmtm @daxpedda