Add warning to ignore synthetic keyboard presses #3717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
reviewed
Jun 5, 2024
There was a problem hiding this comment.
is_synthetic: true is currently only used on X11 and Windows, so I can't really give any input on this, tagging @notgull instead; could you review this (and #3543)?
Perhaps the solution is to fix the X11 backend to not emit a the Tab key event on refocus via. Alt+Tab, similarly to the linked bevy PR?
This is just arbitrary. Such event should just be separate, so for folks who really need it, they can use it. And also in a sense that it just shows what scancodes are pressed or something like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a more prominent warning about synthetic keyboard events, as a simple stopgap for #3543.
I encountered this when reviewing bevyengine/bevy#13696: the existing docs alone were not clear enough for me to determine that synthetic presses should be ignored.
While I suspect that removing them on the winit end is likely better, this is a simple non-breaking improvement.