Web Async Rework #3082
Merged
Web Async Rework #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
reviewed
Sep 3, 2023
|
Once smol-rs/async-channel#59 is merged, would you be able to replace this functionality with |
|
Only the I could look into gating this stuff behind |
daxpedda
force-pushed
the
web-async-rework
branch
from
eacf2a4 to
deab352
Compare
|
This is ready now, but I'm gonna let it simmer for a while. |
daxpedda
force-pushed
the
web-async-rework
branch
from
67aed46 to
d1e368c
Compare
daxpedda
force-pushed
the
web-async-rework
branch
from
d1e368c to
a563b81
Compare
daxpedda
force-pushed
the
web-async-rework
branch
from
a563b81 to
41ebb38
Compare
kchibisov
pushed a commit
to kchibisov/winit
that referenced
this pull request
Oct 17, 2023
kchibisov
pushed a commit
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried splitting up the commits in a way that makes sense to review for others but I also for my own sanity.
This basically doesn't use a channel anymore but a simple
AtomicUsizeto measure the amount of user events sent to appropriately wake up the event loop instead of letting the event loop restart for every user event. Also drops thestd::mpscchannel which should improve the "performance" as well.I added a bunch of related improvements on top as well.
Follow-up to #3081.