-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add direct builder
methods
#3066
Conversation
What's the motivation behind those changes though, besides import? I'm not sure I really get the motivation behind all of that. |
Only motivation is to reduce the number of imports / things the user has to think about, and to hopefully make it easier to see at a glance which type you're constructing. |
But it's not like you can't request a builder on your own and it's not like we don't have |
Definitely true, and there's no other point to deprecating the old methods other than keeping a slightly cleaner API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @madsmtm, the stuff you've done lately improves the API a lot!
Needs rebase. |
Similarly for EventLoop::with_user_event and EventLoopBuilder::with_user_event
Signed-off-by: John Nunley <[email protected]>
Add methods
EventLoop::builder
andWindow::builder
, which allows creating the related builders without having to import them. See the examples for how things look cleaner.Unsure about whether we should deprecate the old methods or not?
CHANGELOG.md
if knowledge of this change could be valuable to users