-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Occluded events based on foreground/background on iOS and MemoryWarning on iOS/Android #2980
Add Occluded events based on foreground/background on iOS and MemoryWarning on iOS/Android #2980
Conversation
That's really nice, thank you! From my reading, to be maximally cross-platform compatible, it sounds like we should send an artificial |
Hmm, actually it sounds like |
@rib: Is there an event on Android that requests the application to pause things (e.g. pause the game) and go into a low-power state, without necessarily suspending everything? |
85fe4f5
to
60a597f
Compare
Is it OK if I add those artificial events on other platforms, with a TODO to move them to the correct events on Android for now? |
cd0ddbe
to
3d1bf95
Compare
Web should probably use these for the |
If the whole intent is to stop rendering based on foreground/background |
My suggestion was to use both, Maybe I'm misunderstanding |
I mean, what's the reason to add them, if |
For the same reason this PR adds |
@daxpedda it's simply a hint saying that you could stop rendering. |
I agree, that's why I am proposing to send both, because |
@daxpedda I'm just arguing against adding special events for |
That said, that limit on iOS at least is quite blurry as it's not possible to have more than one window, so it may be ok to mix those there... |
I mean, as long as window is not destroyed it's fine to use |
3d1bf95
to
c90bf8e
Compare
Moved to |
Adopted from #2144, and updated.
From #2144 (comment) I'm not confident on adding events
Foreground
andBackground
to Android, they seem to be equivalent toSuspend
/Resume
where iOS split that in two steps.CHANGELOG.md
if knowledge of this change could be valuable to users