Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to use raw-window-handle v0.6 #2943

Closed
wants to merge 12 commits into from
Closed

Port to use raw-window-handle v0.6 #2943

wants to merge 12 commits into from

Conversation

notgull
Copy link
Member

@notgull notgull commented Jul 9, 2023 •
edited
Loading

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

cc rust-windowing/raw-window-handle#125

Testing out the new release before it becomes official.

Tests will fail until I also port softbuffer to the new version.

@notgull notgull mentioned this pull request Jul 9, 2023
Closed
5 tasks
@notgull notgull mentioned this pull request Jul 10, 2023
Merged
@daxpedda daxpedda mentioned this pull request Jul 10, 2023
Merged
daxpedda
daxpedda approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web part approved.

madsmtm
madsmtm requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MacOS and iOS impls approved.

Cargo.toml Show resolved Hide resolved
src/event_loop.rs Outdated Show resolved Hide resolved
src/event_loop.rs Show resolved Hide resolved
@madsmtm
Copy link
Member

madsmtm commented Aug 31, 2023

I'd argue this is blocked on #3075

@notgull notgull mentioned this pull request Sep 20, 2023
Merged
@notgull notgull mentioned this pull request Oct 1, 2023
Merged
5 tasks
@notgull
Copy link
Member Author

notgull commented Oct 14, 2023

Obsoleted by #3126

@notgull notgull closed this Oct 14, 2023
@notgull notgull deleted the rwh-0.6 branch October 14, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchibisov kchibisov kchibisov left review comments

@madsmtm madsmtm madsmtm requested changes

@daxpedda daxpedda daxpedda approved these changes

@jackpot51 jackpot51 Awaiting requested review from jackpot51 jackpot51 will be requested when the pull request is marked ready for review jackpot51 is a code owner

@MarijnS95 MarijnS95 Awaiting requested review from MarijnS95 MarijnS95 will be requested when the pull request is marked ready for review MarijnS95 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notgull @madsmtm @daxpedda @kchibisov