-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Window::theme
on the web
#2687
Add support for Window::theme
on the web
#2687
Conversation
I think this change is useful as is, so IMHO shouldn't prevent to be merged. But it could also emit the ThemeChanged event when the media query changes (using for example |
Winit already implements the part of sending |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a minor nit with the changelog, otherwise looks fine
Good point, applied:). Feel free to choose merge with squash. (Or I can also force push a squash if you prefer) |
Don't have a preference for how you do the commits, they'll be squashed once merged anyhow ;) I'll need you to fix the conflicting changelog though, since I don't have write access to your fork. |
Oops, not sure why that permission isn't there. I rebased, squashed, and resolved the conflict. |
Thanks! |
CHANGELOG.md
if knowledge of this change could be valuable to users