Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gate more dependencies #1743

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

kchibisov
Copy link
Member

Wayland backend is self contained and only requires
smithay-client-toolkit to work, thus feature gate the
rest of the deps that are only for X11.

Wayland backend is self contained and only requires
smithay-client-toolkit to work, thus feature gate the
rest of the deps that are only for X11.
@kchibisov kchibisov requested a review from chrisduerr October 17, 2020 19:00
Copy link
Contributor

@chrisduerr chrisduerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as CI is happy, everything should be good.

@kchibisov kchibisov merged commit ee3996c into rust-windowing:master Oct 17, 2020
@kchibisov kchibisov deleted the remove-mio-dep-wayland branch October 17, 2020 23:05
@aloucks
Copy link
Contributor

aloucks commented Nov 7, 2020

This reintroduces an issue where the same dependency is specified multiple times (e.g. parking_lot). This created issues in the past where the dependency was updated in one place, but not in the others. This was fixed in #884.

@kchibisov
Copy link
Member Author

This reintroduces an issue where the same dependency is specified multiple times (e.g. parking_lot). This created issues in the past where the dependency was updated in one place, but not in the others. This was fixed in #884.

It's not an issue if someone can at least look at the code when they are bumping things, if they just blindly merge nothing can be done a tthis point.

@chrisduerr
Copy link
Contributor

Also you say that, but this PR removed the duplicate objc dependency which did actually use different versions. So it basically just doesn't change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants