-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Clone for 'static events #1478
Conversation
Ideally, we should wait for #1456 and then just add a derive impl. |
I agree, current design is not ideal, but if no other approach is found, this is a way to get Clone safely for events. |
afd4b81
to
a74dec3
Compare
a74dec3
to
f737151
Compare
Heya, is it okay to get this merged (and perhaps published) before a big Since a refactor would be a breaking change anyway, I don't see any harm in allowing downstream projects to depend on a published version with this change, with the prospect that they have to migrate to the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay. This looks good to merge - thanks for pulling it together!
cargo fmt
has been run on this branchcargo doc
builds successfullyCHANGELOG.md
if knowledge of this change could be valuable to usersNot applicable:
There is no reason why 'static events can't be Clone. This unblocks most use cases for cloning safe events while not changing current design significantly.
Blocking WASM + OpenGL implementation for Amethyst ( See amethyst/amethyst#2040)