Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11: Update modifiers with key events #1129

Closed
wants to merge 1 commit into from

Conversation

murarth
Copy link
Contributor

@murarth murarth commented Aug 27, 2019

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@murarth
Copy link
Contributor Author

murarth commented Aug 27, 2019

Solves #1124 for X11, but not Wayland.

Note that I've made no changelog entry yet. I'm hoping maybe I can add a fix for Wayland to this PR before it's merged.

@elinorbgr
Copy link
Contributor

FTR, I'm not sure #1124 needs solving: #1124 (comment), so I'd like that merging this PR waits that we reach a consensus in #1124 first.

@murarth
Copy link
Contributor Author

murarth commented Aug 28, 2019

Closing in favor of a different solution.

@murarth murarth closed this Aug 28, 2019
@murarth murarth deleted the keypress-modifier branch August 28, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants