Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] command key event left and right reverse #808

Closed
TakWolf opened this issue Mar 9, 2019 · 2 comments
Closed

[macOS] command key event left and right reverse #808

TakWolf opened this issue Mar 9, 2019 · 2 comments
Labels
B - bug Dang, that shouldn't have happened D - easy Likely easier than most tasks here DS - macos

Comments

@TakWolf
Copy link
Contributor

TakWolf commented Mar 9, 2019

Left command => RWin

KeyboardInput { scancode: 55, state: Pressed, virtual_keycode: Some(RWin), modifiers: ModifiersState { shift: false, ctrl: false, alt: false, logo: true } }


Right command => LWin

KeyboardInput { scancode: 54, state: Pressed, virtual_keycode: Some(LWin), modifiers: ModifiersState { shift: false, ctrl: false, alt: false, logo: true } }

@TakWolf
Copy link
Contributor Author

TakWolf commented Mar 9, 2019

winit version: 0.19.0

@Osspial
Copy link
Contributor

Osspial commented Mar 9, 2019

Looks like the key-codes are just swapped around in the key-code mapping function. The official key-code list doesn't actually list a key-code for right command, so it seems like it would be a pretty easy mistake to make.

This should be a fairly easy problem to fix, so a PR would be welcome.

@Osspial Osspial added B - bug Dang, that shouldn't have happened DS - macos D - easy Likely easier than most tasks here labels Mar 9, 2019
Osspial pushed a commit that referenced this issue Mar 25, 2019
* fix command key event left and right reverse on macOS

#808

* update changelog
@Osspial Osspial closed this as completed Mar 26, 2019
elinorbgr pushed a commit to elinorbgr/winit that referenced this issue Apr 7, 2019
…#810)

* fix command key event left and right reverse on macOS

rust-windowing#808

* update changelog
elinorbgr pushed a commit to elinorbgr/winit that referenced this issue Apr 7, 2019
…#810)

* fix command key event left and right reverse on macOS

rust-windowing#808

* update changelog
felixrabe pushed a commit to felixrabe/winit that referenced this issue Jun 30, 2019
…#810)

* fix command key event left and right reverse on macOS

rust-windowing#808

* update changelog
kosyak pushed a commit to kosyak/winit that referenced this issue Jul 10, 2019
…#810)

* fix command key event left and right reverse on macOS

rust-windowing#808

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B - bug Dang, that shouldn't have happened D - easy Likely easier than most tasks here DS - macos
Development

No branches or pull requests

2 participants