Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize increments should be ignored for maximized windows #2684

Open
chrisduerr opened this issue Feb 12, 2023 · 3 comments · Fixed by #2685
Open

Resize increments should be ignored for maximized windows #2684

chrisduerr opened this issue Feb 12, 2023 · 3 comments · Fixed by #2685
Labels
DS - x11

Comments

@chrisduerr
Copy link
Contributor

Currently when resize increments are used on macOS, maximizing a window will cause it to take up the maximized size closest to the defined resize increments. However resize increments should not take effect when a window is maximized.

See alacritty/alacritty#6696.
@chrisduerr chrisduerr mentioned this issue Feb 12, 2023
Closed
@madsmtm madsmtm added the B - bug Dang, that shouldn't have happened label Feb 12, 2023
@chrisduerr
Copy link
Contributor Author

The same issue seems to apply to Linux: alacritty/alacritty#6696 (comment).

@kchibisov
Copy link
Member

The same issue seems to apply to Linux: alacritty/alacritty#6696 (comment).

Can't repro on GNOME X11. Likely just bugged wm.

kchibisov added a commit to kchibisov/winit that referenced this issue Feb 12, 2023
@kchibisov
On macOS, set resize increments only for live resize
f5dc09f 
Fixes rust-windowing#2684.
@kchibisov kchibisov mentioned this issue Feb 12, 2023
Merged
5 tasks
@kchibisov kchibisov reopened this Feb 15, 2023
@kchibisov kchibisov added DS - x11 and removed B - bug Dang, that shouldn't have happened DS - macos labels Feb 15, 2023
@kchibisov
Copy link
Member

macOS done.

kchibisov added a commit to kchibisov/winit that referenced this issue Feb 15, 2023
@kchibisov
On macOS, set resize increments only for live resize
c51704b 
Fixes rust-windowing#2684.
kchibisov added a commit to kchibisov/winit that referenced this issue Mar 1, 2023
@kchibisov
On macOS, set resize increments only for live resize
4924d42 
Closes rust-windowing#2684 for macOS.
kchibisov added a commit that referenced this issue Mar 2, 2023
@kchibisov
On macOS, set resize increments only for live resize
811cc5c 
Closes #2684 for macOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DS - x11
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

On macOS, set resize increments only for live resize kchibisov/winit
3 participants
@chrisduerr @madsmtm @kchibisov