Skip to content

Commit

Permalink
On macOS, fix Ime::Commit persisting
Browse files Browse the repository at this point in the history
This commit clears the currently marked text on `Ime::Commit`, so
normal `ReceivedCharacter` input can continue.
  • Loading branch information
kchibisov authored Feb 1, 2023
1 parent 4e1c46f commit 3fd7384
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ And please only add new entries to the top of this list, right below the `# Unre

# Unreleased

- On macOS, fixed `Ime::Commit` persisting for all input after interacting with `Ime`.
- On macOS, added `WindowExtMacOS::option_as_alt` and `WindowExtMacOS::set_option_as_alt`.
- On Windows, fix window size for maximized, undecorated windows.
- On Windows and macOS, add `WindowBuilder::with_active`.
Expand Down
5 changes: 4 additions & 1 deletion src/platform_impl/macos/view.rs
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,8 @@ declare_class!(

let is_control = string.chars().next().map_or(false, |c| c.is_control());

if self.is_ime_enabled() && !is_control {
// Commit only if we have marked text.
if self.hasMarkedText() && self.is_ime_enabled() && !is_control {
self.queue_event(WindowEvent::Ime(Ime::Preedit(String::new(), None)));
self.queue_event(WindowEvent::Ime(Ime::Commit(string)));
self.state.ime_state = ImeState::Commited;
Expand Down Expand Up @@ -496,6 +497,8 @@ declare_class!(

// If the text was commited we must treat the next keyboard event as IME related.
if self.state.ime_state == ImeState::Commited {
// Remove any marked text, so normal input can continue.
*self.marked_text = NSMutableAttributedString::new();
self.state.ime_state = ImeState::Enabled;
text_commited = true;
}
Expand Down

0 comments on commit 3fd7384

Please sign in to comment.